Conversation
Delete `src/gauging.jl` (`VidalITensorNetwork` type + `ITensorNetwork`
round-trip constructor + `vidalitensornetwork_preserve_cache` +
`vidal_gauge_isometry` / `vidal_gauge_isometries` + `gauge_error`),
drop the corresponding `apply(::Union{NamedEdge, ITensor}, ::VidalITensorNetwork; ...)`
method from `src/apply.jl`, remove `include("gauging.jl")` from
`src/ITensorNetworks.jl`, delete `test/test_gauging.jl`, and trim the
Vidal cases out of `test/test_apply.jl` (leaving the SBP/GBP/exact
fidelity comparisons in place).
A few imports previously available inside `ITensorNetworks` as a side
effect of `using` clauses in `src/gauging.jl` are now added directly
to the files that use them:
- `ITensors.NDTensors: scalartype` in `src/apply.jl` and
`src/abstractitensornetwork.jl`
- `ITensors: tags` in `src/apply.jl` and `src/abstractitensornetwork.jl`
Bump to 0.18.0 (breaking, pre-1.0 minor bump) and update pinned
`ITensorNetworks` compat in `test/`, `docs/`, and `examples/` Project.toml.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
- Coverage 72.51% 71.04% -1.47%
==========================================
Files 71 70 -1
Lines 3496 3360 -136
==========================================
- Hits 2535 2387 -148
- Misses 961 973 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete
VidalITensorNetworkand its supporting machinery —src/gauging.jl(188 lines), theapply(::Union{NamedEdge, ITensor}, ::VidalITensorNetwork; ...)method insrc/apply.jl(~72 lines), andtest/test_gauging.jl. Trim the Vidal cases out oftest/test_apply.jl(the SBP/GBP/exact fidelity comparisons stay).Breaking:
VidalITensorNetworktype removed, along withvidalitensornetwork_preserve_cache,vidal_gauge_isometry/vidal_gauge_isometries,gauge_error, theITensorNetwork(::VidalITensorNetwork; ...)round-trip constructor,update(::VidalITensorNetwork; ...), and theapply(gate, ::VidalITensorNetwork; ...)specialization.Downstream impact
Tennis.jl: no Vidal uses (GitHub code search).
Other ITensor-org repos: no hits.
Third-party consumers with Vidal usage (out-of-scope for this org but worth noting):
VidalITensorNetwork(ψ)VidalITensorNetwork+gauge_error+bond_tensorsBoth are pinned and will be protected by SemVer (0.17 → 0.18 breaking). They'll stay on 0.17.x until they choose to migrate.
Incidental import cleanups
A few imports were previously available inside
ITensorNetworksas a side effect ofusingclauses insrc/gauging.jl. They are now imported directly by the files that actually use them:ITensors.NDTensors: scalartype—src/apply.jl,src/abstractitensornetwork.jlITensors: tags—src/apply.jl,src/abstractitensornetwork.jlVersion
Bumps to
0.18.0(pre-1.0 minor bump = breaking) and updates pinnedITensorNetworkscompat intest/,docs/, andexamples/Project.toml.